Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destination: Fix flakey TestEndpointProfileTranslator #12182

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

olix0r
Copy link
Member

@olix0r olix0r commented Feb 29, 2024

TestEndpointProfileTranslator could race against the consumer task so that the final queue insertion would not necessarily fail. The send buffer has been eliminated to avoid this race.

Verified

This commit was signed with the committer’s verified signature.
huangzhen1997 Joe Huang
For unknown reasons, the TestEndpointProfileTranslator test fails in
CI occaisionally. This change adds logging to help diagnose the issue.
@olix0r olix0r requested a review from a team as a code owner February 29, 2024 15:36

Verified

This commit was signed with the committer’s verified signature.
huangzhen1997 Joe Huang
@olix0r olix0r changed the title destination: Log queue length in flakey test destination: Fix flakey TestEndpointProfileTranslator Feb 29, 2024
Copy link
Member

@alpeb alpeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, now the flakiness appears to be with CodeQL 🤷

@olix0r olix0r merged commit e1ab0a2 into main Feb 29, 2024
32 of 33 checks passed
@olix0r olix0r deleted the ver/ep-trans-fix branch February 29, 2024 16:59
@klingerf
Copy link
Contributor

This test appears to still be failing in CI: https://github.com/linkerd/linkerd2/actions/runs/8270978365/job/22629718777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants