Rename meshTls to meshTLS in ExternalWorkload CRD #12098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ExternalWorkload resource we introduced has a minor naming inconsistency; `Tls` in `meshTls` is not capitalised. Other resources that we have (e.g. authentication resources) capitalise TLS (and so does Go, it follows a similar naming convention). We fix this in the workload resource by changing the field's name and bumping the version to `v1beta1`. Upgrading the control plane version will continue to work without downtime. However, if an existing resource exists, the policy controller will not completely initialise. It will not enter a crashloop backoff, but it will also not become ready until the resource is edited or deleted. Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
alpeb
reviewed
Feb 19, 2024
alpeb
reviewed
Feb 19, 2024
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
Signed-off-by: Matei David <[email protected]>
olix0r
approved these changes
Feb 20, 2024
Merged
olix0r
added a commit
that referenced
this pull request
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename meshTls to meshTLS in ExternalWorkload CRD
The ExternalWorkload resource we introduced has a minor naming
inconsistency;
TlsinmeshTlsis not capitalised. Other resourcesthat we have (e.g. authentication resources) capitalise TLS (and so does
Go, it follows a similar naming convention).
We fix this in the workload resource by changing the field's name and
bumping the version to
v1beta1.Upgrading the control plane version will continue to work without
downtime. However, if an existing resource exists, the policy controller
will not completely initialise. It will not enter a crashloop backoff,
but it will also not become ready until the resource is edited or
deleted.
Signed-off-by: Matei David [email protected]