inject: Configure proxy stream lifetime limits #11837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkerd/linkerd2-proxy#2587 adds configuration parameters that bound the lifetime and idle times of control plane streams. This change helps to mitigate imbalanced control plane replica usage and to generally prevent scenarios where a stream becomes "stuck," as has been observed when a control plane replica is unhealthy. This change adds helm values to control this behavior. Default values are provided.
olix0r
force-pushed
the
ver/proxy-control-timeout
branch
from
d0ebecd to
e1b6b26
Compare
alpeb
approved these changes
Dec 27, 2023
| @@ -44,6 +44,12 @@ env: | |||
| value: {{.Values.proxy.defaultInboundPolicy}} | |||
| - name: LINKERD2_PROXY_POLICY_CLUSTER_NETWORKS | |||
| value: {{.Values.clusterNetworks | quote}} | |||
| - name: LINKERD2_PROXY_CONTROL_STREAM_INITIAL_TIMEOUT | |||
| value: {{((.Values.proxy.control).streams).initialTimeout | default "" | quote}} | |||
There was a problem hiding this comment.
Are the extra parentheses a protection against empty objects?
There was a problem hiding this comment.
Yeah this will prevent erroring. https://stackoverflow.com/questions/59795596/how-to-make-nested-variables-optional-in-helm/68807258#68807258
Merged
olix0r
added a commit
that referenced
this pull request
Dec 28, 2023
This edge release includes fixes and improvements to the destination controller's endpoint resolution API. * Fixed an issue in the control plane where discovery for pod IP addresses could hang indefinitely ([#11815]) * Updated the proxy to enforce time limits on control plane response streams so that proxies more naturally distribute load over control plane replicas ([#11837]) * Fixed the policy's controller service metadata responses so that proxy logs and metrics have informative values ([#11842])
olix0r
added a commit
that referenced
this pull request
Dec 28, 2023
This edge release includes fixes and improvements to the destination controller's endpoint resolution API. * Fixed an issue in the control plane where discovery for pod IP addresses could hang indefinitely ([#11815]) * Updated the proxy to enforce time limits on control plane response streams so that proxies more naturally distribute load over control plane replicas ([#11837]) * Fixed the policy's controller service metadata responses so that proxy logs and metrics have informative values ([#11842])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linkerd/linkerd2-proxy#2587 adds configuration parameters that bound the lifetime and idle times of control plane streams. This change helps to mitigate imbalanced control plane replica usage and to generally prevent scenarios where a stream becomes "stuck," as has been observed when a control plane replica is unhealthy.
This change adds helm values to control this behavior. Default values are provided.