Reenable cni-calico-deep integration test #11617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have continue-on-error set on other workflows. Should we? Why should this job be handled differently? How was the error being hidden such that changing continue-on-error will prevent that problem? |
|
I've made a separate change for the continue-on-error behavior: #11630 |
olix0r
reviewed
Nov 17, 2023
olix0r
added a commit
that referenced
this pull request
Nov 17, 2023
We have `continue-on-error: true` marked on several integration workflows. It appears that GitHub's behavior has changed to now mark these tests as green even when they fail. This change removes this setting from integration tests so errors are reported properly. It also disables cni-calico-deep until #11617 is merged.
Fixes #11567 The trick is to run the test under k8s `v1.27.6-k3s1` as the following versions break Calico in k3s (see k3d-io/k3d#1375). Also removed the `continue-on-error: true` directive in the integration workflow because it was hiding this problem.
alpeb
force-pushed
the
alpeb/calico-reenable
branch
from
ac23edd to
0d79029
Compare
|
In my latest commit I've moved the k3d config file and refactored in |
…handle the declaration of bindir and testdir
alpeb
force-pushed
the
alpeb/calico-reenable
branch
from
0d79029 to
2d9ec0e
Compare
olix0r
approved these changes
Nov 17, 2023
adleong
approved these changes
Nov 17, 2023
alpeb
added a commit
that referenced
this pull request
Dec 7, 2023
After having fixed it via #11617 we had reenabled it for the release workflow but not for the integration workflow.
olix0r
pushed a commit
that referenced
this pull request
Dec 7, 2023
After having fixed it via #11617 we had reenabled it for the release workflow but not for the integration workflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11567
The trick is to run the test under k8s
v1.27.6-k3s1as the following versions break the calico CNI plugin in k3s (see k3d-io/k3d#1375).Also removed the
continue-on-error: truedirective in the integration workflow because it was hiding this problem.