Fix error for profile lookups on unmeshed pods with port in default opaque list #11550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
olix0r
requested changes
Oct 31, 2023
Signed-off-by: Alex Leong <[email protected]>
adleong
commented
Oct 31, 2023
| @@ -55,25 +55,6 @@ func (ept *endpointProfileTranslator) Update(address *watcher.Address) (bool, er | |||
| return false, fmt.Errorf("failed to create endpoint: %w", err) | |||
| } | |||
|
|
|||
| // The protocol for an endpoint should only be updated if there is a pod, | |||
There was a problem hiding this comment.
All of this protocol hinting logic is already implemented in createWeightedAddr and the endpoint that we get from createEndpoint already has the protocol hinting metadata set on it correctly. This code block is redundant.
There was a problem hiding this comment.
Is this function unit tested? Shouldn't a test break somewhere if so?
olix0r
reviewed
Oct 31, 2023
Signed-off-by: Alex Leong <[email protected]>
olix0r
changed the title
Signed-off-by: Alex Leong <[email protected]>
olix0r
reviewed
Nov 20, 2023
Signed-off-by: Alex Leong <[email protected]>
olix0r
approved these changes
Nov 30, 2023
alpeb
approved these changes
Dec 20, 2023
controller/api/destination/server.go
Outdated
Comment on lines
282
to
286
| if err != nil { | ||
| log.Errorf("Failed to subscribe to profile by ip %q: %q", dest.GetPath(), err) | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| log.Errorf("Failed to subscribe to profile by ip %q: %q", dest.GetPath(), err) | |
| return err | |
| } | |
| return nil | |
| if err != nil { | |
| log.Errorf("Failed to subscribe to profile by ip %q: %q", dest.GetPath(), err) | |
| } | |
| return err |
controller/api/destination/server.go
Outdated
Comment on lines
290
to
294
| if err != nil { | ||
| log.Errorf("Failed to subscribe to profile by name %q: %q", dest.GetPath(), err) | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| log.Errorf("Failed to subscribe to profile by name %q: %q", dest.GetPath(), err) | |
| return err | |
| } | |
| return nil | |
| if err != nil { | |
| log.Errorf("Failed to subscribe to profile by name %q: %q", dest.GetPath(), err) | |
| } | |
| return err |
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
Merged
adleong
added a commit
that referenced
this pull request
Dec 20, 2023
This edge release contains improvements to the logging and diagnostics of the destination controller. * Added a control plane metric to count errors talking to the Kubernetes API ([#11774]) * Fixed an issue causing spurious destination controller error messages for profile lookups on unmeshed pods with port in default opaque list ([#11550]) [#11774]: #11774 [#11550]: #11550 Signed-off-by: Alex Leong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we do a
GetProfilelookup for an unmeshed pod, we set theweightedAddr.ProtocolHintto an empty value&pb.ProtocolHint{}to indicate that the address is unmeshed and has no protocol hint. However, when the looked up port is in the default opaque list, we erroneously check ifweightedAddr.ProtocolHint != nilto determine if we should attempt to get the inbound listen port for that pod. Since&pb.ProtocolHint{} != nil, we attempt to get the inbound listen port for the unmeshed pod. This results in an error, preventing any validGetProfileresponses from being returned.We update the initialization logic for
weightedAddr.ProtocolHintto only create a struct when a protocol hint is present and to leave it asnilif the pod is unmeshed.We add a simple unit test for this behavior as well.