Add PDB for tap and tap-injector #11249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget. This commit adds the respective PDB objects following the core components implementation to the `tap` and `tap-injector` deployments. It can be enabled with the enablePodDisruptionBudget helm chart value. Fixes linkerd#11248 Signed-off-by: Matias Charriere <[email protected]>
|
Nice! I'm wondering if the PodDisruptionBudgets should apply to the other deployments in linkerd-viz as well, namely |
|
Hi @mcharriere, I'm going to close this PR due to lack of activity. Please feel free to re-open if you'd like to pick this back up again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid disruption during cluster nodes rolling or scaling, it's desired to complement the maxUnavailable from the rolling strategy with a PodDisruptionBudget.
This commit adds the respective PDB objects following the core components implementation to the
tapandtap-injectordeployments. It can be enabled with the enablePodDisruptionBudget helm chart value.Fixes #11248