-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an EndpointsWatcher cache structure #11190
Merged
+603
−4
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
d194044
Introduce an EndpointsWatcher cache structure
mateiidavid 2e4f1e9
Handle error
mateiidavid 3e1266b
Add graceful shutdown for informers
mateiidavid ab6d71e
Add first tests for endpoints watcher cache
mateiidavid 1362d73
Fix comments
mateiidavid 213f5db
Add more tests for endpoints watcher cache
mateiidavid 1081968
Re-visit comments and fix lints
mateiidavid 907c22e
Fix logs for Stop() function in Endpointswatcher
mateiidavid 45f8fab
Remove Endpoints access when using EndpointSlices
mateiidavid ce70d12
Rename EndpointsWatcherCache to ClusterStore
mateiidavid 3d64ca9
Actually remove old files
mateiidavid 6172527
Review feedback
mateiidavid 90ffd35
Remove Len() from cluster store
mateiidavid 501e57a
Release lock in test
mateiidavid 50db8fd
Sync API clients async
mateiidavid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could even go a step further and sync each of these in their own goroutine to sync them in parallel.