Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana Integration tracking ticket #420

Closed
14 of 16 tasks
siggy opened this issue Feb 22, 2018 · 1 comment
Closed
14 of 16 tasks

Grafana Integration tracking ticket #420

siggy opened this issue Feb 22, 2018 · 1 comment

Comments

@siggy
Copy link
Member

siggy commented Feb 22, 2018

Summary

With Prometheus already a first-class component of Conduit, Grafana is a natural extension of that deployment, enabling visualization of Conduit telemetry data. This ticket documents tasks to achieve preliminary Grafana integration for the next Conduit release.

Context: https://docs.google.com/document/d/12Cfzc6ghuxs93xXl1QSvUxFjU4mwJLaNcxBykvgF7Fg

Prototype: #101

Tasks

@siggy siggy added this to the Conduit 0.3.1 milestone Feb 22, 2018
@siggy siggy self-assigned this Feb 22, 2018
siggy added a commit that referenced this issue Feb 22, 2018
The template used by `conduit install` was hard-coded in install.go.

This change moves the template into its own file, in anticipation of
increasing the template's size and complexity.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Feb 23, 2018
The template used by `conduit install` was hard-coded in install.go.

This change moves the template into its own file, in anticipation of
increasing the template's size and complexity.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Feb 23, 2018
The template used by `conduit install` was hard-coded in install.go.

This change moves the template into its own file, in anticipation of
increasing the template's size and complexity.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
@olix0r olix0r modified the milestone: Conduit 0.3.1 Feb 23, 2018
@olix0r olix0r added the priority/P1 Planned for Release label Feb 23, 2018
siggy added a commit that referenced this issue Feb 24, 2018
`conduit install` deploys prometheus, but lacks a general-purpose way to
visualize that data.

This change adds a Grafana container to the `conduit install` command. It
includes two sample dashboards, viz and health, in their own respective
source files.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
@olix0r olix0r added priority/P2 Nice-to-have for Release and removed priority/P1 Planned for Release labels Feb 26, 2018
siggy added a commit that referenced this issue Feb 27, 2018
`conduit install` deploys prometheus, but lacks a general-purpose way to
visualize that data.

This change adds a Grafana container to the `conduit install` command. It
includes two sample dashboards, viz and health, in their own respective
source files.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Feb 28, 2018
`conduit install` deploys prometheus, but lacks a general-purpose way to
visualize that data.

This change adds a Grafana container to the `conduit install` command. It
includes two sample dashboards, viz and health, in their own respective
source files.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Feb 28, 2018
`conduit install` deploys prometheus, but lacks a general-purpose way to
visualize that data.

This change adds a Grafana container to the `conduit install` command. It
includes two sample dashboards, viz and health, in their own respective
source files.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Feb 28, 2018
`conduit install` deploys prometheus, but lacks a general-purpose way to
visualize that data.

This change adds a Grafana container to the `conduit install` command. It
includes two sample dashboards, viz and health, in their own respective
source files.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Mar 5, 2018
Grafana dashboards will not be available for the 0.3.1, but BUILD.md
provides an (incorrect) way to access Grafana.

Remove mention of Grafana for now. Re-add when dashboards are integrated
into Conduit.

Part of #420.

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Mar 5, 2018
Grafana dashboards will not be available for the 0.3.1 release, but
BUILD.md provides an (incorrect) way to access Grafana.

Remove mention of Grafana for now. Re-add when dashboards are integrated
into Conduit.

Part of #420.

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Mar 6, 2018
Grafana dashboards will not be available for the 0.3.1 release, but
BUILD.md provides an (incorrect) way to access Grafana.

Remove mention of Grafana for now. Re-add when dashboards are integrated
into Conduit.

Part of #420.

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy modified the milestones: 0.3.1, 0.4.0 Mar 6, 2018
@olix0r olix0r removed the priority/P2 Nice-to-have for Release label Mar 12, 2018
siggy added a commit that referenced this issue Mar 13, 2018
Existing Grafana configuration contained no dashboards, just a skeleton
for testing.

Introduce two Grafana dashboards:
1) Top Line: Overall health of all Conduit-enabled services
2) Deployment: Health of a specific conduit-enabled deployment

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 4, 2018
Previously the only way to access the Grafana dashboards was via direct
link, provided by the `conduit dashboard` command.

Add Grafana links throughout the Conduit Dashboard, next to all
Deployment objects. This change also modifies the behavior of the
ConduitLink helper, to enable linking to other deployments proxied by
the `conduit dashboard` command.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 4, 2018
Using a vanilla Grafana Docker image as part of `conduit install`
avoided maintaining a conduit-specific Grafana Docker image, but made
packaging dashboard json files cumbersome.

Roll our own Grafana Docker image, that includes conduit-specific
dashboard json files. This significantly decreases the `conduit install`
output size, and enables dashboard integration in the docker-compose
environment.

Fixes #567
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 5, 2018
Using a vanilla Grafana Docker image as part of `conduit install`
avoided maintaining a conduit-specific Grafana Docker image, but made
packaging dashboard json files cumbersome.

Roll our own Grafana Docker image, that includes conduit-specific
dashboard json files. This significantly decreases the `conduit install`
output size, and enables dashboard integration in the docker-compose
environment.

Fixes #567
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 5, 2018
Using a vanilla Grafana Docker image as part of `conduit install`
avoided maintaining a conduit-specific Grafana Docker image, but made
packaging dashboard json files cumbersome.

Roll our own Grafana Docker image, that includes conduit-specific
dashboard json files. This significantly decreases the `conduit install`
output size, and enables dashboard integration in the docker-compose
environment.

Fixes #567
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 5, 2018
Previously the only way to access the Grafana dashboards was via direct
link, provided by the `conduit dashboard` command.

Add Grafana links throughout the Conduit Dashboard, next to all
Deployment objects. This change also modifies the behavior of the
ConduitLink helper, to enable linking to other deployments proxied by
the `conduit dashboard` command.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 6, 2018
* Link to Grafana from Conduit Dashboard

Previously the only way to access the Grafana dashboards was via direct
link, provided by the `conduit dashboard` command.

Add Grafana links throughout the Conduit Dashboard, next to all
Deployment objects. This change also modifies the behavior of the
ConduitLink helper, to enable linking to other deployments proxied by
the `conduit dashboard` command.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>

* review feedback

Signed-off-by: Andrew Seigner <[email protected]>

* review feedback, fix console, remove absolute

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 6, 2018
The Grafana dashboards key off of deployment, but had no awareness of
namespaces, causing incorrect metrics aggregation and display.

This change makes the Grafana dashboards key off of namespaces, and also
modifies the Grafana links in the Conduit dashboard to link to
namespace+deployment.

Fixes #704
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 6, 2018
The Grafana dashboards key off of deployment, but had no awareness of
namespaces, causing incorrect metrics aggregation and display.

This change makes the Grafana dashboards key off of namespaces, and also
modifies the Grafana links in the Conduit dashboard to link to
namespace+deployment.

Fixes #704
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 6, 2018
The Grafana dashboards key off of deployment, but had no awareness of
namespaces, causing incorrect metrics aggregation and display.

This change makes the Grafana dashboards key off of namespaces, and also
modifies the Grafana links in the Conduit dashboard to link to
namespace+deployment.

Fixes #704
Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue Apr 14, 2018
The top-line, deployments, and health Grafana dashboards had
inconsistent layouts and data.

This change standardizes our Grafana dashboards. Every row is composed
of Success Rate, Request Rate, and Latency.

Part of #420.

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy removed this from the 0.4.0 milestone Apr 14, 2018
siggy added a commit that referenced this issue Apr 14, 2018
The top-line, deployments, and health Grafana dashboards had
inconsistent layouts and data.

This change standardizes our Grafana dashboards. Every row is composed
of Success Rate, Request Rate, and Latency.

Part of #420.

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue May 7, 2018
Grafana provides default dashboards for Prometheus and Grafana health.
The community also provides Kubernetes-specific dashboards. Conduit was
not taking advantage of these.

Introduce new Grafana dashboards focused on Grafana, Kubernetes, and
Prometheus health. Tag all Conduit dashboards for easier UI navigation.
Also fix layout in Conduit Health dashboard.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue May 7, 2018
Grafana provides default dashboards for Prometheus and Grafana health.
The community also provides Kubernetes-specific dashboards. Conduit was
not taking advantage of these.

Introduce new Grafana dashboards focused on Grafana, Kubernetes, and
Prometheus health. Tag all Conduit dashboards for easier UI navigation.
Also fix layout in Conduit Health dashboard.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue May 8, 2018
Grafana provides default dashboards for Prometheus and Grafana health.
The community also provides Kubernetes-specific dashboards. Conduit was
not taking advantage of these.

Introduce new Grafana dashboards focused on Grafana, Kubernetes, and
Prometheus health. Tag all Conduit dashboards for easier UI navigation.
Also fix layout in Conduit Health dashboard.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue May 8, 2018
Grafana provides default dashboards for Prometheus and Grafana health.
The community also provides Kubernetes-specific dashboards. Conduit was
not taking advantage of these.

Introduce new Grafana dashboards focused on Grafana, Kubernetes, and
Prometheus health. Tag all Conduit dashboards for easier UI navigation.
Also fix layout in Conduit Health dashboard.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
siggy added a commit that referenced this issue May 8, 2018
Grafana provides default dashboards for Prometheus and Grafana health.
The community also provides Kubernetes-specific dashboards. Conduit was
not taking advantage of these.

Introduce new Grafana dashboards focused on Grafana, Kubernetes, and
Prometheus health. Tag all Conduit dashboards for easier UI navigation.
Also fix layout in Conduit Health dashboard.

Part of #420

Signed-off-by: Andrew Seigner <[email protected]>
@siggy
Copy link
Member Author

siggy commented Sep 24, 2018

Only remaining tasks are #706 and #709. Closing this tracking ticket.

@siggy siggy closed this as completed Sep 24, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants