Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart to allow for configuration of updateStrategy #13031

Closed
sstarcher opened this issue Sep 5, 2024 · 6 comments · Fixed by #13562
Closed

helm chart to allow for configuration of updateStrategy #13031

sstarcher opened this issue Sep 5, 2024 · 6 comments · Fixed by #13562

Comments

@sstarcher
Copy link
Contributor

What problem are you trying to solve?

Large amount of daemonsets can take a long time to update unless rolling update strategy can not be changed to a percent

How should the problem be solved?

Allow update strategy to be configurable.

Any alternatives you've considered?

No

How would users interact with this feature?

They would be able to configure the setting themselves without patching.

Would you like to work on this feature?

maybe

@olix0r
Copy link
Member

olix0r commented Sep 6, 2024

What workloads does this apply to? You reference DaemonSets, so I assume this is specific to the linkerd-cni chart?

@sstarcher
Copy link
Contributor Author

Yes that is correct the linkerd-cni chart daemonset

Copy link

stale bot commented Dec 19, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 19, 2024
@sstarcher
Copy link
Contributor Author

Can you please leave this as not stale.

@stale stale bot removed the wontfix label Dec 19, 2024
@sstarcher
Copy link
Contributor Author

If you will accept a PR for this I can put that in fairly trivially

@alpeb
Copy link
Member

alpeb commented Jan 9, 2025

Sorry for the late reply @sstarcher ; yes, we'd be glad to review a PR for this 👍

sstarcher pushed a commit to sstarcher/linkerd2 that referenced this issue Jan 10, 2025
* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

linkerd#13031
sstarcher pushed a commit to sstarcher/linkerd2 that referenced this issue Jan 14, 2025
* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

linkerd#13031
Signed-off-by: Shane Starcher <[email protected]>
sstarcher pushed a commit to sstarcher/linkerd2 that referenced this issue Jan 14, 2025
* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

linkerd#13031
Signed-off-by: Shane Starcher <[email protected]>
sstarcher pushed a commit to sstarcher/linkerd2 that referenced this issue Jan 17, 2025
* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

linkerd#13031
Signed-off-by: Shane Starcher <[email protected]>
alpeb pushed a commit that referenced this issue Jan 21, 2025
* [feat] allow cni updateStrategy to be configurable

* For users with large clusters rollout of the cni can take a bit of
  time. This will allow them to configure a faster rollout of the cni
resources.

#13031
Signed-off-by: Shane Starcher <[email protected]>

* add update strategy for cli

Signed-off-by: Shane Starcher <[email protected]>

---------

Signed-off-by: Shane Starcher <[email protected]>
Co-authored-by: Shane Starcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants