Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy-controller validating admission webhook doesn't validate gateway.networking.kubernetes.io HTTPRoutes #11116

Closed
hawkw opened this issue Jul 14, 2023 · 0 comments · Fixed by #11150

Comments

@hawkw
Copy link
Contributor

hawkw commented Jul 14, 2023

What is the issue?

While working on other changes to the policy controller, I noticed that the validating admission webhook validates the policy.linkerd.io version of the HTTPRoute CRD, but not the upstream gateway.networking.kubernetes.io version. We should probably perform the same validation for both HTTPRoute objects.

How can it be reproduced?

n/a

Logs, error output, etc

n/a

output of linkerd check -o short

n/a

Environment

  • Linkerd 2.13+

Possible solution

We should probably add an implementation of the validating admission controller logic for both versions of HTTPRoute.

Additional context

No response

Would you like to work on fixing this bug?

yes

@hawkw hawkw added the bug label Jul 14, 2023
@risingspiral risingspiral added this to the stable-2.14.0 milestone Jul 20, 2023
mikutas added a commit to mikutas/linkerd2 that referenced this issue Jul 23, 2023
mikutas added a commit to mikutas/linkerd2 that referenced this issue Jul 26, 2023
to the policy-controller

Fixes linkerd#11116

Signed-off-by: Takumi Sue <[email protected]>
mikutas added a commit to mikutas/linkerd2 that referenced this issue Jul 29, 2023
to the policy-controller

Fixes linkerd#11116

Signed-off-by: Takumi Sue <[email protected]>
adleong pushed a commit that referenced this issue Sep 25, 2023
Fixes #11116

Signed-off-by: Takumi Sue <[email protected]>
Co-authored-by: Alejandro Pedraza <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants