chore(proxy/http): address hyper deprecations in ServeHttp<N>
#3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
approved these changes
Dec 13, 2024
Base automatically changed from
kate/hyper-1.x-workspace-dependency-pt-2-upgrade
to
main
December 13, 2024 16:16
cratelyn
force-pushed
the
kate/hyper-1.x-proxy-http-deprecations
branch
from
0b23cd7 to
fbac483
Compare
cratelyn
force-pushed
the
kate/hyper-1.x-proxy-http-deprecations
branch
from
fbac483 to
78f728c
Compare
cratelyn
changed the base branch from
main
to
kate/hyper-1.x-fix-bad-merge-remove-duplicate-fn
Base automatically changed from
kate/hyper-1.x-fix-bad-merge-remove-duplicate-fn
to
main
December 13, 2024 16:38
see linkerd/linkerd2#8733 for more information on upgrading to hyper 1.0. this commit is based upon #3456, and #3457. this commit is also contingent upon hyperium/hyper#3796, which backports the server connection builder's `max_pending_accept_reset_streams()` method. this commit addresses hyper deprecations in `ServeHttp<N>`, which defines a reusable HTTP/1 and HTTP/2 server for the linkerd proxy. essentially, this commit replaces the singular `Http<E>` with a pair of http/1 and http/2 specific connection `Builder`s. method names no longer have `http2_*` prefixes, otherwise nothing about the connection setup has been changed. in the `Service` implementation, we delegate to the appropriate builder based upon the protocol version. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-proxy-http-deprecations
branch
from
78f728c to
4b44e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see linkerd/linkerd2#8733 for more information on upgrading to hyper 1.0.
this commit is based upon #3456, and #3457.
this commit is also contingent upon hyperium/hyper#3796, which backports the server connection builder's
max_pending_accept_reset_streams()method.this commit addresses hyper deprecations in
ServeHttp<N>, which defines a reusable HTTP/1 and HTTP/2 server for the linkerd proxy.essentially, this commit replaces the singular
Http<E>with a pair of http/1 and http/2 specific connectionBuilders. method names no longer havehttp2_*prefixes, otherwise nothing about the connection setup has been changed. in theServiceimplementation, we delegate to the appropriate builder based upon the protocol version.