chore(hyper): address miscellaneous deprecations #3444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is a trivial deprecation fix, for <linkerd/linkerd2#8733>. Signed-off-by: katelyn martin <[email protected]>
see <linkerd/linkerd2#8733>. this updates some test code to use the backported server connection interfaces. Signed-off-by: katelyn martin <[email protected]>
this commit addresses uses of deprecated hyper interfaces in the `linkerd-app-integration` crate. see <linkerd/linkerd2#8733>. Signed-off-by: katelyn martin <[email protected]>
cratelyn
force-pushed
the
kate/hyper-1.x-address-tap-server-deprecation
branch
from
85527ed to
1caf9d0
Compare
cratelyn
changed the title
Http deprecation
cratelyn
force-pushed
the
kate/hyper-1.x-address-tap-server-deprecation
branch
from
701e3a4 to
19dee60
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cratelyn
force-pushed
the
kate/hyper-1.x-address-tap-server-deprecation
branch
from
19dee60 to
1caf9d0
Compare
cratelyn
commented
Dec 11, 2024
| #[allow(deprecated)] // linkerd/linkerd2#8733 | ||
| let mut http = hyper::server::conn::Http::new().with_executor(TracingExecutor); | ||
| http.http2_only(true); | ||
| let http = hyper::server::conn::http2::Builder::new(TracingExecutor); |
There was a problem hiding this comment.
an example of what we are doing here: replacing conn::Http values with a conn::http2::Builder or conn::http1::Builder as contextually appropriate.
this was fixed in a previous commit. Signed-off-by: katelyn martin <[email protected]>
olix0r
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this branch addresses a small assortment of calls to deprecated hyper interfaces.
see linkerd/linkerd2#8733.