feat(outbound): Add per-route stream timeout policies #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olix0r
force-pushed
the
ver/route-timeout
branch
4 times, most recently
from
a1f68b3 to
9a4a19f
Compare
olix0r
force-pushed
the
ver/route-timeout
branch
from
9a4a19f to
432b712
Compare
olix0r
force-pushed
the
ver/route-timeout
branch
2 times, most recently
from
2a62c91 to
b75dbb8
Compare
This change adds a new timeout configuration to the outbound HTTP and gRPC policies that sets request extensions to configure timeout behavior in the endpoint stack. This ensures that timeouts manifest as endpoint-level errors (i.e. visible to endpoint-level circuit breakers) instead of as a route-level cancellation. Several timeouts are implemented: 1. A request timeout, which is the maximum time a full request-response stream can remain in the proxy. 2. A response headers timeout that limits the amount of time after the request has been fully sent in which response headers must be fully received. This will be used to implement retry timeouts. 3. A response timeout, which limits the amount of time after the request has been fully sent in which a response may be in flight. 4. An idle timeout that limits the time a request-response stream may be sit in the proxy without any DATA frame activity. NOTE: As this timeout is enforced in the endpoint stack, it is currently possible for requests to remain in the balancer queue until a failfast timeout is tripped. The configured timeouts only apply to requests that have been dequeued and dispatched to an endpoint. NOTE: A followup API change is required to support configuring all timeouts via the API.
olix0r
force-pushed
the
ver/route-timeout
branch
from
b75dbb8 to
ef6586b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new timeout configuration to the outbound HTTP and gRPC policies that sets request extensions to configure timeout behavior in the endpoint stack. This ensures that timeouts manifest as endpoint-level errors (i.e. visible to endpoint-level circuit breakers) instead of as a route-level cancellation.
Several timeouts are implemented:
NOTE: As this timeout is enforced in the endpoint stack, it is currently possible for requests to remain in the balancer queue until a failfast timeout is tripped. The configured timeouts only apply to requests that have been dequeued and dispatched to an endpoint.
NOTE: A followup API change is required to support configuring all timeouts via the API.