fix(pool): Reset endpoints gauge on drop #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The p2c pool tracks an endpoints gauge that is incremented and decremented as endpoints are added and removed from the balancer. When a balancer is dropped, the proxy does not reset this gauge to 0. If the balancer is recreated later, this causes endpoints to appear to be double-counted. This commit fixes this in two ways: 1. When the balancer is dropped, the endpoints gauge is reset to 0. 2. When the pool is reset (i.e., during initialization), we always reset the endpoints value rather than use individual inc/dec calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The p2c pool tracks an endpoints gauge that is incremented and decremented as endpoints are added and removed from the balancer. When a balancer is dropped, the proxy does not reset this gauge to 0. If the balancer is recreated later, this causes endpoints to appear to be double-counted.
This commit fixes this in two ways: