http: Parameterize NewServeHttp #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to add defensive timeouts to the HTTP server to limit idle streams and connections. In preparation for this, we need to parameterize the server to accept these additonal configurations. This change updates NewServeHttp to use an ExtractParam to build a Params struct for each server. In follow-up changes, the timeout configuration will be instrumented through this Params struct. There are no functional changes in this commit.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2696 +/- ##
==========================================
+ Coverage 67.64% 67.68% +0.04%
==========================================
Files 332 332
Lines 15149 15158 +9
==========================================
+ Hits 10247 10260 +13
+ Misses 4902 4898 -4
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 16, 2024
--- * build(deps): bump rcgen from 0.11.3 to 0.12.0 (linkerd/linkerd2-proxy#2677) * build(deps): bump jobserver from 0.1.26 to 0.1.27 (linkerd/linkerd2-proxy#2679) * build(deps): bump bumpalo from 3.12.0 to 3.14.0 (linkerd/linkerd2-proxy#2678) * outbound: Log and remove l5d-proxy-error from responses (linkerd/linkerd2-proxy#2694) * http: Parameterize NewServeHttp (linkerd/linkerd2-proxy#2696) * gateway: Avoid double http prefixing in metric names (linkerd/linkerd2-proxy#2701) Signed-off-by: Oliver Gould <[email protected]>
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Feb 19, 2024
--- * build(deps): bump rcgen from 0.11.3 to 0.12.0 (linkerd/linkerd2-proxy#2677) * build(deps): bump jobserver from 0.1.26 to 0.1.27 (linkerd/linkerd2-proxy#2679) * build(deps): bump bumpalo from 3.12.0 to 3.14.0 (linkerd/linkerd2-proxy#2678) * outbound: Log and remove l5d-proxy-error from responses (linkerd/linkerd2-proxy#2694) * http: Parameterize NewServeHttp (linkerd/linkerd2-proxy#2696) * gateway: Avoid double http prefixing in metric names (linkerd/linkerd2-proxy#2701) Signed-off-by: Oliver Gould <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan to add defensive timeouts to the HTTP server to limit idle streams and connections. In preparation for this, we need to parameterize the server to accept these additonal configurations.
This change updates NewServeHttp to use an ExtractParam to build a Params struct for each server. In follow-up changes, the timeout configuration will be instrumented through this Params struct.
There are no functional changes in this commit.