orig-proto: Avoid emiting HTTP/2 errors for upgraded requests #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our error handlers need to account for the fact that HTTP/1 requests may fail with HTTP/2 errors due to orig-proto upgrading. To simplify error handling (in an upcoming change), the `orig_proto::Upgrade` service introduces a new error type, `orig_proto::DowngradedH2Error` that hides the original error source so that these errors are not detected as being an `h2::Error`.
olix0r
commented
Sep 7, 2021
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 9, 2021
This release improves error handling so that HTTP metrics include 5XX responses for common errors. Logging has also been improved to ensure `inbound` and `outbound` spans are always present in log messages. Outbound tap has been fixed to include route labels when service profiles are configured. --- * Set tracing spans on policy client (linkerd/linkerd2-proxy#1241) * build(deps): bump tokio-util from 0.6.7 to 0.6.8 (linkerd/linkerd2-proxy#1240) * core: fix missing spans in `serve` tasks (linkerd/linkerd2-proxy#1243) * build(deps): bump thiserror from 1.0.28 to 1.0.29 (linkerd/linkerd2-proxy#1244) * orig-proto: Avoid emiting HTTP/2 errors for upgraded requests (linkerd/linkerd2-proxy#1245) * Fix route labels on outbound tap metadata (linkerd/linkerd2-proxy#1247) * errors: Support contextual error handling strategies (linkerd/linkerd2-proxy#1246)
olix0r
added a commit
to linkerd/linkerd2
that referenced
this pull request
Sep 9, 2021
This release improves error handling so that HTTP metrics include 5XX responses for common errors. Logging has also been improved to ensure `inbound` and `outbound` spans are always present in log messages. Outbound tap has been fixed to include route labels when service profiles are configured. --- * Set tracing spans on policy client (linkerd/linkerd2-proxy#1241) * build(deps): bump tokio-util from 0.6.7 to 0.6.8 (linkerd/linkerd2-proxy#1240) * core: fix missing spans in `serve` tasks (linkerd/linkerd2-proxy#1243) * build(deps): bump thiserror from 1.0.28 to 1.0.29 (linkerd/linkerd2-proxy#1244) * orig-proto: Avoid emiting HTTP/2 errors for upgraded requests (linkerd/linkerd2-proxy#1245) * Fix route labels on outbound tap metadata (linkerd/linkerd2-proxy#1247) * errors: Support contextual error handling strategies (linkerd/linkerd2-proxy#1246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our error handlers need to account for the fact that HTTP/1 requests may
fail with HTTP/2 errors due to orig-proto upgrading.
To simplify error handling (in an upcoming change), the
orig_proto::Upgradeservice introduces a new error type,orig_proto::DowngradedH2Errorthat hides the original error source sothat these errors are not detected as being an
h2::Error.