Fix issues with Idea plugin and presto tests #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoustafa
reviewed
May 14, 2019
| @@ -101,7 +107,13 @@ private static Properties loadDefaultVersions() { | |||
|
|
|||
| private static DependencyConfiguration getDependencyConfiguration(ConfigurationType configurationType, | |||
| String module, String platform) { | |||
| return new DependencyConfiguration(configurationType, | |||
| module + ":" + DEFAULT_VERSIONS.getProperty(platform + "-version")); | |||
| return getDependencyConfiguration(configurationType, module, platform, null); | |||
There was a problem hiding this comment.
Overload the method instead of passing null and checking inside with an if condition
There was a problem hiding this comment.
That would lead to code duplication. I am not sure if code duplication is better than having a simple if condition.
wmoustafa
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
presto-main:testsis a transitive dependency oftransportable-udfs-test-presto, but some POM to IVY converters drop dependency classifiers, so we apply this dependency explicitly.