Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated importlib.resources.*. #249

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

jsirois
Copy link
Contributor

@jsirois jsirois commented Jan 5, 2024

This was deprecated in Python 3.11, which shiv officially supports, and
it's gone in 3.13.

This was deprecated in Python 3.11, which shiv officially supports, and
it's gone in 3.13.
@jsirois
Copy link
Contributor Author

jsirois commented Jan 5, 2024

It looks like the RTD CI step has been failing since October. Fix hopefully off in #250.

@jsirois jsirois changed the title Replace deprecated importlib.resources.contents. Replace deprecated importlib.resources.*. Jan 6, 2024
@jsirois
Copy link
Contributor Author

jsirois commented Jan 6, 2024

This is working for conscript 0.1.7 on Python 3.13 which uses shiv in its examples and tests: https://github.com/jsirois/conscript/pull/8/files#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449

Copy link
Contributor

@lorencarvalho lorencarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsirois !

@lorencarvalho lorencarvalho merged commit 094b31a into linkedin:main Feb 5, 2024
1 check failed
@jsirois jsirois deleted the 3.13/prep branch February 5, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants