Added a null check for the htmlDir in PyCoverageTask #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvezdan
reviewed
Nov 26, 2019
pygradle-plugin/src/main/groovy/com/linkedin/gradle/python/tasks/PyCoverageTask.groovy
Outdated
Show resolved
Hide resolved
elautz
force-pushed
the
coverage-null-path
branch
from
ab31c19 to
378bb6f
Compare
Handling of an edge case: If the user configures the project to run covergae but there is no coverage output (i.e. no coverage to report), the htmlDir parsed from the output will ultimately be null, and thus the call to project.file(htmlDir) fails with IllegalArgumentException: path may not be null or empty string. path='null'
elautz
force-pushed
the
coverage-null-path
branch
from
378bb6f to
cb03227
Compare
zvezdan
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of an edge case: If the user configures the project
to run covergae but there is no coverage output (i.e. no
coverage to report), the htmlDir parsed from the output will
ultimately be null, and thus the call to project.file(htmlDir)
fails with IllegalArgumentException: path may not be null or
empty string. path='null'