Add two more items to the substitution map #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pythonExecutable names the full path to the Python executable that the pex will be shebanged with. * toolName is the project name, which can form the basis of the pex file name
|
Tested locally; I'm not sure there's an existing test for the original placeholders. |
|
Hmm, not sure how my changes could have broken that test. Is it a CircleCI problem perhaps? Trying a clean local build to see if that reproduces the failure. |
|
Thanks @ethankhall - it was just a transient connectivity problem. Build kicked and it passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will be shebanged with.
Closes #207