fix for null pointers in TaskList returned by MapReduceFSFetcherHadoop2 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Use ArrayList instead (2) Add unit test for this
paulbramsen
approved these changes
Feb 9, 2017
| @@ -142,4 +150,64 @@ public void testGetHistoryDir() { | |||
| Assert.assertNull("Failed to initialize FileSystem", e); | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetTaskData() { | |||
There was a problem hiding this comment.
Nice! Additional test coverage is always good.
|
+1 |
skakker
pushed a commit
to skakker/dr-elephant
that referenced
this pull request
Dec 14, 2017
…p2 (linkedin#203) (1) Use ArrayList instead (2) Add unit test for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For MapReduce jobs with succeeded status but containing failed tasks (by setting mapreduce.map.failures.maxpercent to non zero), MapReduceFSFetcherHadoop2 will construct a task list with null pointers. This PR fixes this bug and adds a unit test to distinguish it.