skip endOfPeriodMarker in stream method #104
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the windowOffset calculate method is diffrent between relay and client . Client filters the endOfPeriodMarker event as follows:
if (e.isEndOfPeriodMarker())
{ ... }
else if (e.isCheckpointMessage())
{ ... }
else // regular dbusEvent
{
if (currentWindowScn == e.sequence())
{
++currentWindowOffset;
}
else
{
currentWindowScn = e.sequence();
currentWindowOffset = 1L;
}
}
but when the client stream events from relay , the filter method like this:
if (state == EventScanningState.FOUND_WINDOW_ZONE)
{
if (skippedMessages < messagesToSkip)
{
++skippedMessages;
continue;
}
else
{
state = EventScanningState.VALID_ZONE;
}
}
}
so when transaction has a lot events and the client's buffer is full.the windowOffset may be not right and the consumer may consume a event twice.