Make java and python build requirement more clear in README #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinGe00
changed the title
wmoustafa
reviewed
Jan 31, 2024
README.md
Outdated
| @@ -66,12 +66,13 @@ git clone https://github.com/linkedin/coral.git | |||
|
|
|||
| Build: | |||
|
|
|||
| **Important:** | |||
wmoustafa
reviewed
Jan 31, 2024
README.md
Outdated
| @@ -66,12 +66,13 @@ git clone https://github.com/linkedin/coral.git | |||
|
|
|||
| Build: | |||
|
|
|||
| **Important:** | |||
| Please note that this project requires Python 3 and Java 8 to run. Set `JAVA_HOME` to the home of an appropriate version and then use: | |||
There was a problem hiding this comment.
You can make the first sentence bold.
wmoustafa
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
Adding clarity to Java and python versioning requirements for build in README after user reported some confusion.