Support translating Spark SQL to Calcite RelNode #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
12 times, most recently
from
511bbd1 to
b2a93fe
Compare
wmoustafa
reviewed
Jan 17, 2023
...park/src/main/java/com/linkedin/coral/spark/spark2rel/Spark2CoralOperatorTransformerMap.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
from
b2a93fe to
5969c9c
Compare
|
The APIs that this PR touches are undergoing some changes. They should land soon. Let us check this in once the APIs are checked in. cc: @aastha25 @ljfgem @yiqiangin |
|
I heard the above refactorign is still in progress and ETA is the end of June. I will update this PR once it's complete. |
|
Will this PR help me solve the conversion from SparkSQL to HiveSQL? |
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
3 times, most recently
from
27d56fb to
085d221
Compare
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
4 times, most recently
from
b7adde3 to
4e58449
Compare
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
2 times, most recently
from
6fd19aa to
59aeec7
Compare
ebyhr
force-pushed
the
ebi/spark-to-rel-v2
branch
from
59aeec7 to
7507454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #330
I didn't write design docs as the approach is similar to Trino module and nothing special. Let me know if such documentation is due. The main work is
SparkSqlAstVisitor. The class requires some cleanup and overriding more methods for throwing exceptions in unsupported syntax. Some classes (e.g.OperatorTransformer) were copied from Trino module.