Pass down precision/scale when casting to DECIMAL #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jongn
changed the title
|
@ljfgem PTAL if you get the chance, thanks! |
|
@jongn Thank you so much for fixing it. |
|
Thanks @ljfgem, added the spark tests. I'll add corresponding Trino tests once this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Trino issue:
trinodb/trino#6450
When casting column to DECIMAL type, precision was not being preserved during the Hive -> Rel translation, resulting in default precision/scale of 10,0 respectively.
This PR is to pass the precision/scale in Hive -> Rel translation, if applicable.