[cherry-pick] add support for flink 1.18 for Beam Flink Runner #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minxhe
changed the title
minxhe
force-pushed
the
minxhe/flink-1-18
branch
from
0bf4a55 to
75715f9
Compare
yananhao12
requested review from
becketqin,
xinyuiscool and
yananhao12
and removed request for
becketqin and
xinyuiscool
yananhao12
reviewed
Nov 25, 2024
Ran into some issues when cherry picking the 1.14 removal PR, let me give it another shot today. |
This test asserts on the message of an AssertionError thrown by a
failing hamcrest assertion. The message changes in the latest versions
of hamcrest.
```
1) testBadCoderIsNotDeterministic(org.apache.beam.sdk.testing.CoderPropertiesTest)
java.lang.AssertionError:
Expected: a string containing "<84>, <101>, <115>, <116>, <68>"
but: was "
Expected: [<24b>, <84b>, <101b>, <115b>, <116b>, <68b>, <97b>, <116b>, <97b>, <51b>, <51b>, <50b>, <54b>, <49b>, <57b>, <57b>, <52b>, <57b>, <48b>, <57b>, <57b>, <55b>, <48b>, <53b>, <53b>]
but: was [<24b>, <84b>, <101b>, <115b>, <116b>, <68b>, <97b>, <116b>, <97b>, <51b>, <51b>, <50b>, <54b>, <49b>, <57b>, <57b>, <52b>, <56b>, <50b>, <48b>, <52b>, <49b>, <54b>, <49b>, <53b>]"
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
at org.apache.beam.sdk.testing.CoderPropertiesTest.testBadCoderIsNotDeterministic(CoderPropertiesTest.java:123)
```
…able batch execution on DataStream API (apache#28614) Co-authored-by: Jiangjie Qin <[email protected]> Co-authored-by: tvalentyn <[email protected]>
* [runners-flink] Remove unnnecessary dependency on flink-annotations * Fix @RequiresStableInput for portable Flink (apache#20812) Fix FlinkRequiresStableInputTest flakiness (apache#21333) * Flink: Tests for stateful stable dofns (apache#20812) * Enable commit for kafka flink portable test * Apply suggestions from code review Co-authored-by: Lukasz Cwik <[email protected]> * Add callback to BufferingDoFnRunner for flushing SDK harness results * revert changes in website Co-authored-by: Lukasz Cwik <[email protected]>
|
@yananhao12 removed |
yananhao12
approved these changes
Nov 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick apache#31062 to add support for flink 1.18 for Beam Flink Runner from apache/beam master
Changes cherrypicked:
Testing:
./gradlew :runners:flink:build :runners:flink:1.18:validatesRunnerpass locally except for testorg.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState, which was observed to be flacky in [Bug]: beam_PostCommit_Java_ValidatesRunner_Flink is flakes in org.apache.beam.sdk.transforms.GroupByKeyTest$BasicTests.testAfterProcessingTimeContinuationTriggerUsingState apache/beam#22913. And it passed in the OSS test runThank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.