Add SASL-SCRAM ability to Kafka connection #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjh-yext
force-pushed
the
rjhyext_sasl-scram
branch
from
103a349 to
bbc59f3
Compare
|
Thanks for contributing. Could you please rebase your PR off of master and run |
This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512 It adds an entry in the SASL Profile configuration called key=mechanism value type=string required=no default value=(empty) Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512 Partially addresses linkedin#526
rjh-yext
force-pushed
the
rjhyext_sasl-scram
branch
from
bbc59f3 to
d5faa58
Compare
rjh-yext
changed the title
andrewchoi5
reviewed
Jan 23, 2020
|
This patch worked for my setup, SCRAM + SASL + TLS, thank you @rjh-yext |
|
Thanks for your work on this PR @rjh-yext. Are you planning to make it ready to be merged into master or can somebody help you with that? |
|
I could provide a patch to fix the linting and merge conflicts, but I'm not sure how to go about that |
|
Thanks for contributing! Shipped with #627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to connect to Kafka via SASL-SCRAM 256 or 512
It adds an entry in the SASL Profile configuration called
key=mechanism
value type=string
required=no
default value=(empty)
Which accepts either values SCRAM-SHA-256, SCRAM-SHA-512
Partially addresses #526