Add a coherent unit test framework #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to mention - this was also spurred by wanting to make a code change to how Literals choose their numeric datatypes, so there's a change there. The idea is that in JS, all numbers are 64 bit IEEE doubles. Integer/double/decmial types are chosen based on the precision of the provided value. |
|
Looks great to me. Thanks for doing this! |
|
Wait a second, what happened to this code? :) I'm not seeing this merged PR in the |
|
:( did someone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort I outlined in #151. This is just meant to create a consistent framework for adding unit tests. Further work will be required for integration/higher level tests.
Given that BDD-style test frameworks have become the de-facto standard, I added
mochaandchai, which are both more actively maintained thantapeandnodeunit. I created some example tests, and converted the old tape tests to the new BDD style as well.I couldn't figure out the
term.jsanduri.jsunit tests that usenodeunit, so I haven't tried to convert them yet, but rather stuck them in their own directory. If someone is more familiar with them, perhaps they could help convert them tomocha.@timbl @dmitrizagidulin thoughts?