Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(format-po): split multi line comments #1980

Merged
merged 5 commits into from
Aug 7, 2024

Conversation

aseerkt
Copy link
Contributor

@aseerkt aseerkt commented Jul 18, 2024

Description

Split multi line comments for better message extraction

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes #1978

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 3, 2024 3:54am

Copy link

github-actions bot commented Jul 18, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.88 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (d6b9698) to head (e334614).
Report is 41 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1980      +/-   ##
==========================================
- Coverage   76.65%   75.50%   -1.15%     
==========================================
  Files          81       85       +4     
  Lines        2090     2139      +49     
  Branches      533      546      +13     
==========================================
+ Hits         1602     1615      +13     
- Misses        375      411      +36     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aseerkt
Copy link
Contributor Author

aseerkt commented Jul 18, 2024

For format-json formatter, the behaviour changes as following. Not sure if this is the expected behaviour

{
  "y90vC+": {
    "translation": "",
    "message": "Bye World",
-   "comments": [
-     "this is multi\n      line comment" 
-   ]
+  "comments": [
+    "this is multi",     
+    "line comment" 
+  ]
  }
}

Should I only account for format-po formatter instead?

@aseerkt aseerkt changed the title chore: split multi line comments chore(cli): split multi line comments Jul 18, 2024
@timofei-iatsenko
Copy link
Collaborator

Should I only account for format-po formatter instead?

Yes, it should be in format-po instead, not a globally for catalog.

@timofei-iatsenko timofei-iatsenko self-requested a review July 29, 2024 08:00
@aseerkt aseerkt changed the title chore(cli): split multi line comments chore(format-po): split multi line comments Aug 3, 2024
@andrii-bodnar andrii-bodnar merged commit bc33e06 into lingui:main Aug 7, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi-line comment not formatted correctly
3 participants