-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(format-po): split multi line comments #1980
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1980 +/- ##
==========================================
- Coverage 76.65% 75.50% -1.15%
==========================================
Files 81 85 +4
Lines 2090 2139 +49
Branches 533 546 +13
==========================================
+ Hits 1602 1615 +13
- Misses 375 411 +36
Partials 113 113 ☔ View full report in Codecov by Sentry. |
For {
"y90vC+": {
"translation": "",
"message": "Bye World",
- "comments": [
- "this is multi\n line comment"
- ]
+ "comments": [
+ "this is multi",
+ "line comment"
+ ]
}
} Should I only account for |
Yes, it should be in format-po instead, not a globally for catalog. |
Description
Split multi line comments for better message extraction
Types of changes
Fixes #1978
Checklist