Add possibility to plug in custom mounts provider #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobgu Thank you so much for the contribution! This looks perfect. I ran CI and fixed one lint and added this to the test case and it all looks great. I'm planning to merge this and get a release out soon. Sorry it took so long to respond 😄 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This relates to #157 which I've revisited now. Ultimately selecting a global version for the KV engine was not flexible enough as it would not allow for secret engines to be mounted in arbitrary locations in the tree.
This PR makes it possible to supply your own mount list through a new interface. It solves the use case I have, which is purely to use vaku as a library. I have not done any changes to the CLI (I'm not sure there are any reasonable changes to be done).
Any feedback is appreciated!