add drop-only option to dae trace #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwinger233
suggested changes
Aug 12, 2024
trace/trace.go
Outdated
| fmt.Fprintf(writer, "\n") | ||
| } | ||
| } | ||
| case "__kfree_skb": |
There was a problem hiding this comment.
用 kfree_skbmem 会不会更好？因为 __kfree_skb() 经常被优化掉。
比如 consume_skb() 的代码是
void consume_skb(struct sk_buff *skb)
{
if (!skb_unref(skb))
return;
trace_consume_skb(skb, __builtin_return_address(0));
__kfree_skb(skb);
}
但是在我 6.5.0-1027-oem 上检查内核的 consume_skb() 汇编：
$ sudo gdb -ex "x/100i 0x$(ksym consume_skb)" -ex q vmlinux /proc/kcore 2>/dev/null
[...]
0xffffffff853fe99f: call 0xffffffff853f9270
[...]
上面的 call 0xffffffff853f9270 是 call kfree_skbmem()，而不是 __kfree_skb，可见后者直接被优化掉了，在内核里经常没有被实际调用。
Co-authored-by: dae-prow[bot] <136105375+dae-prow[bot]@users.noreply.github.com>
linglilongyi
force-pushed
the
drop-only
branch
from
3d6838c to
addf3cf
Compare
Co-authored-by: mzz2017 <[email protected]>
Co-authored-by: dae-prow[bot] <136105375+dae-prow[bot]@users.noreply.github.com>
- refactor: also merge some line to simplify the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Checklist
Full Changelogs
Issue Reference
#2 [[https://github.com/daeuniverse/issues/524]]
Closes #[issue number]
Test Result