Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial frontend #3

Merged
merged 6 commits into from
May 13, 2024
Merged

Initial frontend #3

merged 6 commits into from
May 13, 2024

Conversation

Twey
Copy link
Collaborator

@Twey Twey commented May 11, 2024

Adds a skeleton frontend using Vite and Lit with some rough-and-ready brand styles.

@Twey Twey requested review from christos-h and ndr-ds May 13, 2024 14:45
Copy link

@christos-h christos-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

render = () => html`
<h2>Wallet</h2>
${this.wallet && html`<p>Your current wallet is <span class="chain-id">${this.wallet.default}</span>.</p>`}
<linera-wallet-picker></linera-wallet-picker>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just do <linera-wallet-picker/> or is that exclusively in React?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NET syntax is invalid for custom elements because the browser doesn't know whether the custom element takes a body or not :(

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussion on the spec: WICG/webcomponents#624

@Twey Twey merged commit afc477a into main May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants