Add support for Wasmer in Witty #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare to add support for Wasmer in an optional manner.
Implement the `Runtime` trait for it.
A type to make it easier to handle a Wasmer guest instance while it is being initialized.
Share the actual `wasmer::Instance` type with reentrant calls.
A type to help with the construction of an `EntrypointInstance`.
14 tasks
Add a trait to help with the implementation of `InstanceWithFunction` for Wasmer instance types.
Add a trait to help with the implementation of `InstanceWithFunction` for Wasmer instance types.
Allow calling imported functions using Wasmer.
Allow loading and storing `WitType`s in the memory of Wasmer guest instances.
jvff
force-pushed
the
witty-wasmer
branch
3 times, most recently
from
26b236b to
9e0f76a
Compare
ma2bd
approved these changes
Aug 14, 2023
| impl_instance_with_function!(@generate(ReentrantInstance<'_>) $( $names: $types ),*); | ||
| }; | ||
|
|
||
| (@generate($instance:ty) $( $names:ident : $types:ident ),*) => { |
There was a problem hiding this comment.
nit: Seems like you just need another macro instead of using @generate(..) ?
| /// | ||
| /// The maximum number of parameters is defined by the [canonical | ||
| /// ABI](https://github.com/WebAssembly/component-model/blob/main/design/mvp/CanonicalABI.md#flattening) | ||
| /// as the `MAX_FLAT_PARAMS` constant. |
There was a problem hiding this comment.
The value 16 is hardcoded in this library in various places, right? Maybe explain this in the comment.
There was a problem hiding this comment.
Done. I tried to improve the related documentation and mentioned the MAX_FLAT_* constants so it's easier to grep for them.
Allow the type that exported host functions receive to be able to call imported guest functions reentrantly.
Some simple Wasm modules that will be used during some integration tests.
Reuse the integration tests for `wit_import` using a Wasmer instance.
Build the test modules and run the integration tests with the `wasmer` feature enabled.
Include the name of the constant from the specification, to improve searchability and describe how it's handled in Witty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new Witty crate should generate host code that's compatible with the Wasmer runtime.
Proposal
Create a feature gated
wasmermodule inlinera_witty::runtime, with implementations for the Witty traits. There are twoInstanceimplementations, one for newly created instances (EntrypointInstance) and one for instances made available inside host functions called by the guest module (ReentrantInstance).Test Plan
Reuse the integration tests for
wit_import.Links
Part of #906
Release Plan
Reviewer Checklist