linera-service: move wallet-only operations out of ClientContext
#2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
06-11-Use_WalletState
branch
5 times, most recently
from
f03f018
to
33181d6
Compare
Twey
force-pushed
the
06-11-Use_WalletState
branch
from
33181d6
to
45d2254
Compare
afck
approved these changes
Jun 12, 2024
| @@ -195,7 +147,7 @@ impl ClientContext { | |||
| #[cfg(feature = "rocksdb")] | |||
| None => { | |||
| let storage_config = linera_service::storage::StorageConfig::RocksDb { | |||
| path: Self::create_default_config_path()?.join("wallet.db"), | |||
There was a problem hiding this comment.
I don't think so — there's currently no way to change the config path, so the code is equivalent. But we have such a way for the wallet path, so I thought I might as well move this one so we're ready when we inevitably make it configurable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the future,
ClientContextwill contain aClient, and therefore will not be constructible until a storage client is available.Proposal
Instead of constructing a
ClientContextto do wallet operations in the CLI, just construct aWalletState(a persisted wallet file) instead.Test Plan
CI.
Release Plan
No user-visible changes.
Links