Update Rust to version 1.77.0 #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the latest stable version.
MathieuDutSik
approved these changes
Apr 23, 2024
Twey
approved these changes
Apr 23, 2024
afck
approved these changes
Apr 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While using
async fnin a trait withoutasync_trait, I ran into a compiler warning that was a bit annoying. There is a way around it, by requiring thatSelf: Sized, but it seems like the lint has been removed on the latest stable.Proposal
Update Rust to the latest stable version.
Test Plan
CI should catch any issues with the new Rust version.
Release Plan
If developers use the old version, they'll run into the same lint. It's not a blocker, but it is annoying and might be surprising. So I'd suggest
Links