Create a WitInterface trait to allow creating of WIT interface snippets
#1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jvff
force-pushed
the
wit-interface-trait
branch
2 times, most recently
from
66372fb to
26cfc5f
Compare
afck
reviewed
Apr 11, 2024
Comment on lines
+149
to
+155
| std::borrow::Cow::Borrowed(" "), | ||
| #wit_name.into(), | ||
| ": func(".into(), | ||
| #( #parameters, #commas )* | ||
| ")".into(), | ||
| #( #output, )* | ||
| ";".into(), |
There was a problem hiding this comment.
I'm still confused: Somehow I expected this would be a string literal, but it doesn't create any quotes (")?
There was a problem hiding this comment.
I'm not sure I understand the question 😅 This creates a String object, using the slice::join method applied to strings. This is very similar to concat!, but some WitTypes might need to build String objects, so this concatenates a list of Cow<'static, str>.
There was a problem hiding this comment.
Ah, right, and wit_name and parameters are string literals, of course. 👍
jvff
commented
Apr 11, 2024
Representation of a type that can be written as a WIT interface.
Prepare to allow the code used to generate `WitInterface` implementations to access helper types used by the `wit_import` and `wit_export` macros.
Implement the code to generate `WitInterface` implementations, so that it can be used by the `wit_export` and `wit_import` macros.
Prepare to access the `AttributeParameters` when generating code later.
Implement `WitInterface` for the type generated by the `wit_import` macro, so that the `trait` can be used to obtain its expected WIT interface.
Implement `WitInterface` for the type the `wit_export` macro is applied to, so that the `impl` block can be used to obtain its exported WIT interface.
Asserts if the WIT type dependencies for a type that implements `WitInterface` are the expected types.
Asserts if the WIT function declarations of a type that implements `WitInterface` matches the expected declarations.
Ensure all the methods return the expected WIT snippets.
Ensure all the methods return the expected WIT snippets.
Ensure all the methods of the types used in the reentrancy tests return the expected WIT snippets.
Ensure all the `WitInterface` methods return the expected WIT snippets.
Follow the Rust convention for function documentation. Co-authored-by: Andreas Fackler <[email protected]> Signed-off-by: Janito Vaqueiro Ferreira Filho <[email protected]>
Fix typo in the word "function". Co-authored-by: Andreas Fackler <[email protected]> Signed-off-by: Janito Vaqueiro Ferreira Filho <[email protected]>
Fix typo in the word "function". Signed-off-by: Janito Vaqueiro Ferreira Filho <[email protected]>
jvff
force-pushed
the
wit-interface-trait
branch
from
c21b271 to
bb9d66d
Compare
afck
approved these changes
Apr 11, 2024
Comment on lines
+149
to
+155
| std::borrow::Cow::Borrowed(" "), | ||
| #wit_name.into(), | ||
| ": func(".into(), | ||
| #( #parameters, #commas )* | ||
| ")".into(), | ||
| #( #output, )* | ||
| ";".into(), |
There was a problem hiding this comment.
Ah, right, and wit_name and parameters are string literals, of course. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Witty will allow generating WIT files from Rust items. To achieve that goal, it needs to generate WIT interfaces.
Proposal
Create a
WitInterfacetrait that provides the WIT snippets and type dependencies necessary for the interface. Automatically generate the implementation of this trait from#[wit_export]and#[wit_import]macros.Test Plan
The expected snippets are now checked in the integration tests.
Release Plan
Only affects Witty, so nothing needed.
Links