Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: derives for AaSupport #654

Merged
merged 3 commits into from
Aug 6, 2024
Merged

feat: derives for AaSupport #654

merged 3 commits into from
Aug 6, 2024

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Aug 4, 2024 •
edited
Loading

Doesn't play well with bevy_vello since I can't interoperate these types or clone, etc.

DJMcNab
DJMcNab reviewed Aug 5, 2024
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We really should enable some of the clippy lints in this repository as well.

See the one comment for the blocking concern.

vello/src/lib.rs Outdated Show resolved Hide resolved
@simbleau @DJMcNab
Update vello/src/lib.rs
d0b5795 
Co-authored-by: Daniel McNab <[email protected]>
@simbleau simbleau requested a review from DJMcNab August 5, 2024 17:43
@simbleau simbleau added this pull request to the merge queue Aug 6, 2024
Merged via the queue into linebender:main with commit 0808fa0 Aug 6, 2024
17 checks passed
@simbleau simbleau deleted the simbleau/aasupport-derives branch August 6, 2024 14:16
@waywardmonkeys waywardmonkeys added this to the Vello 0.3 release milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys approved these changes

@DJMcNab DJMcNab Awaiting requested review from DJMcNab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Vello 0.3 release
Development

Successfully merging this pull request may close these issues.
3 participants
@simbleau @waywardmonkeys @DJMcNab