Allow access to adapter #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Thanks! I'm planning on exploring a much more well-thought through API, but this makes the util more useful.
Fwiw, the intention of util is that if you need something which util doesn't provide, you should be able to use the lower-level primitives yourself. But as I say, very little API design work has gone into Vello, so that might not be possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no way to access the adapter outside of Vello, which prevents users of Vello from doing things like checking surface capabilities. This pull request exposes the adapter.