Implement workaround to prevent panics with empty scenes #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Superseded by #630 |
DJMcNab
added a commit
to DJMcNab/vello
that referenced
this pull request
Jul 16, 2024
Alternative to linebender#629 Fixes linebender#291
DJMcNab
added a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know someone is going to answer: "This isn't the optimal solution, we should fix this problem at the root and add checks to the GPU pipelines to avoid the panics".
Yes, well, people have been saying we should do that for months, and the panic is still here. If someone wants to implement the proper solution, they can do so after this is merged.
People are still having crashes because of this. We need a fix last month, pretty or not.