Test that Renderer + Scene are Send.
#556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted this in my own integration, but was reminded when I saw the change from |
waywardmonkeys
force-pushed
the
test-send
branch
2 times, most recently
from
fe2f1f3 to
0cfe8fd
Compare
DJMcNab
approved these changes
Apr 22, 2024
waywardmonkeys
force-pushed
the
test-send
branch
2 times, most recently
from
77a7f32 to
31f361e
Compare
The `Renderer` will no be `Send` on wasm32 targets due to differences in the underlying `wgpu` library (unless a feature is enabled for `wgpu`). Usages within Bevy and other frameworks are simpler when these types are `Send`.
waywardmonkeys
force-pushed
the
test-send
branch
from
31f361e to
d879c15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usages within Bevy and other frameworks are simpler when these types are
Send.