-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: repo documentation, crate names #552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has something changed in the status of #518?
We should try and settle that before doing this renaming
The other changes seem mostly fine, although I find the aversion to title case in the changelog slightly strange
Co-authored-by: Daniel McNab <[email protected]>
That is a good callout. My guess was that #518 work fell through the cracks to higher priorities. @xorgy - Is the rename from vello_svg to demo_svg ok? My motivation was to fix having two vello_svgs around.
I just copied other CHANGELOGs, which don't capitalize. But nonetheless I applied your suggestion, we can use capitals. |
finished rebasing @DJMcNab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It'll be good to get changelogs started, even if we've not quite settled on the exact format yet
Co-authored-by: Daniel McNab <[email protected]>
Co-authored-by: Daniel McNab <[email protected]>
Co-authored-by: Daniel McNab <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes: