Additional test cases for co-linear stroked curves #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
approved these changes
Feb 23, 2024
| path.push(QuadTo(quad[0].into(), quad[1].into())); | ||
| } | ||
| let x = (idx % NUM_COLS) as f64 * CELL_SIZE; | ||
| let y = (idx / NUM_COLS) as f64 * CELL_SIZE; |
There was a problem hiding this comment.
These now go off screen at the default window size
There was a problem hiding this comment.
I can adjust the CELL_SIZE to adapt to the number of rows (which fixes this on my external monitor).
The layout in general is sensitive to DPI, e.g. at the default window dimensions, everything fits and looks tiny on my MacBook's retina display, but enlarged on my external monitor. I've observed this with all the other test scenes too.
There was a problem hiding this comment.
The test scene now initializes the resolution field of SceneParams, which fixes the issue for me.
|
We have a new Android CI check so you'll need to rebase on |
armansito
force-pushed
the
more-flat-stroke-tests
branch
from
261b748 to
cdd3381
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported over some additional test cases from Skia's "tricky cubic strokes" tests that exercise co-linear quadratic curves. These used to render incorrectly until the recent kurbo update, so it's good to have these in Vello.
These new curves are technically conic sections with cusps in them (with weights 1, 0.3, and 1.5). Vello doesn't yet support rational Beziers, so Skia encodes a conic as a path composed of quadratics (with a tolerance of 0.25 which scaled by the applied transform). The new test cases encode the results of this conic->quad conversion.