vello_svg: Use affine transformation #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… data Correctly apply the transformation for other parameters as well (e.g stroke width)
msiglreith
force-pushed
the
svg-transform
branch
from
e92b39a to
5aaf288
Compare
DJMcNab
approved these changes
Mar 9, 2023
integrations/vello_svg/src/lib.rs
Outdated
| @@ -65,14 +65,22 @@ pub fn render_tree_with<F: FnMut(&mut SceneBuilder, &usvg::Node) -> Result<(), E | |||
| ) -> Result<(), E> { | |||
| for elt in svg.root.descendants() { | |||
| let transform = elt.abs_transform(); | |||
| let transform = Affine::new([ | |||
| transform.a, | |||
| transform.b, | |||
There was a problem hiding this comment.
This is some nasty code. Technically,
let usvg::Transform { a, b, c, d, e, f } = elt.abs_transform();
let transform = Affine::new([a, b, c, d, e, f]);takes up less vertical space. It's a shame usvg::Transform doesn't provide a to_array or equivalent, but I haven't found one
There was a problem hiding this comment.
thanks, updated that part
|
@msiglreith according to my information, you should be able to merge this PR. Standard procedure in our repos is for the author to merge them after approving review. (Also, you should be eligible for org membership; we don't have a process for arranging that, but if you want it, let me know on Zulip (in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the affine transformation option from vello instead of directly transforming the path data.
This correctly applies the transformation for other parameters as well (e.g stroke width).
Test file: https://w3.impa.br/~diego/projects/Neh20/inputs/timings/spiral.svg