-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and improve Rect methods #117
Conversation
I was considering adding another |
path/src/rect.rs
Outdated
Some(*self) | ||
} else if ts.has_skew() { | ||
// we need to transform all 4 corners | ||
let tl = Point { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Point::from_xy
would be formatted more nicely.
Thanks. Looks good to me. As for |
This adds Rect::join and is_empty (matching skia's) and improves the speed of from_points and transform.
The overhead is primarily the excessive |
I understand the use case, but I don't think it should be in tiny-skia. |
whoops, I meant to mark it as ready last comment |
This adds Rect::join and is_empty (matching skia's) and improves the speed of from_points and transform.