Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add helpers functions to PathSegment #47

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

add helpers functions to PathSegment #47

wants to merge 8 commits into from

Conversation

Its-Just-Nans
Copy link

Hi

Here his a tiny PR to add to helpers functions for PathSegment

@RazrFalcon
Copy link
Collaborator

I would suggest is_abs and command(&self) -> u8 {} for "letters".

@Its-Just-Nans
Copy link
Author

Thanks for the feedback

I'v updated the code

@Its-Just-Nans Its-Just-Nans marked this pull request as draft February 26, 2025 17:49
@Its-Just-Nans
Copy link
Author

I'm drafting it because I want to add others functions

@Its-Just-Nans Its-Just-Nans marked this pull request as ready for review February 26, 2025 17:58
@RazrFalcon
Copy link
Collaborator

Sorry, but that's too much. svgtypes should provide only parsing utilities. Everything else should be implemented on the callers side.

is_abs and command are fine, but everything else should be removed.

@Its-Just-Nans
Copy link
Author

Its-Just-Nans commented Feb 27, 2025 •
edited
Loading

Also the Display ?

Removed

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Its-Just-Nans @RazrFalcon