Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization for paths with markers in paint-order but not actual markers #887

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

LaurenzV
Copy link
Contributor

No description provided.

@LaurenzV
Copy link
Contributor Author

Fixes #884.

@DJMcNab
Copy link
Member

DJMcNab commented Feb 26, 2025

Is this marked in GitHub as not fixing #884 for any particular reason?

@LaurenzV
Copy link
Contributor Author

Not really, I thought writing "Fixes xy" will automatically do that. 😅 TIL

@LaurenzV LaurenzV linked an issue Feb 26, 2025 that may be closed by this pull request
@DJMcNab
Copy link
Member

DJMcNab commented Feb 26, 2025

It does if you put it in the description, but you put it in a follow-up comment (the only reason to do it that way would be to avoid the autofixing, hence my confusion)

Copy link
Collaborator

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good simplification of the logic here.

@waywardmonkeys
Copy link
Collaborator

Does this need a changelog?

@LaurenzV
Copy link
Contributor Author

I guess I will add it in the Version bump PR.

@LaurenzV LaurenzV merged commit 3f6e85c into main Feb 26, 2025
10 checks passed
@LaurenzV LaurenzV deleted the optimizemarker branch February 26, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty ID for path
3 participants