Account for inline boxes when collapsing after newlines #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. the windows "restore lfs cache" task is generating a different cache key to linux/mac and is then not finding the cached LFS files. |
wfdewith
reviewed
Feb 18, 2025
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
whitespace-collapsing-fix
branch
from
f51d789 to
5cdaa45
Compare
Signed-off-by: Nico Burns <[email protected]>
nicoburns
force-pushed
the
whitespace-collapsing-fix
branch
from
5cdaa45 to
5e7b1fb
Compare
Signed-off-by: Nico Burns <[email protected]>
|
(For reference, the thread is https://xi.zulipchat.com/#narrow/channel/419691-linebender/topic/Parley.20CI.20failing.20.28due.20to.20LFS.20failure.3F.29) |
wfdewith
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup (small bug fix) to #254 which didn't take inline boxes into account. That PR was checking whether "the last character is whitespace" without checking whether the last thing pushed into the layout was text.
So if the sequence of items pushed to a layout was something like:
(an example which would be "status badges" in Github readme's which are typically images separated by whitespace characters)
Then all but the first "whitespace" would get collapsed as it would be incorrectly detected as directly adjacent to the preceding whitespace (even though it shouldn't because there is an inline box in between).
This PR fixes this issue by tracking the kind of the last item pushed.