Add PlainEditor method to get IME cursor area
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The area reported is the area of text the user is currently editing. It is usually used by platforms to place a candidate box for IME near it, while ensuring it is not obscured. The implementation here ensures the area is usually near the focus, that the area contains at least some surrounding context (in case the platform places something to the side of the area, instead of above or under), and that the IME candidate box usually does not need to jump around when the IME starts or continues composing.
DJMcNab
approved these changes
Dec 10, 2024
examples/vello_editor/src/main.rs
Outdated
| @@ -340,6 +358,7 @@ fn main() -> Result<()> { | |||
| scene: Scene::new(), | |||
| editor: text::Editor::new(text::LOREM), | |||
| last_drawn_generation: Default::default(), | |||
| last_sent_ime_cursor_area: None, | |||
There was a problem hiding this comment.
Maybe this should be an arbitrary definitely invalid rect? E.g. 0x0 at (0, 0) or similar
There was a problem hiding this comment.
It's now flattened and splatted with NaN, which should definitely never be returned.
| // until https://github.com/rust-windowing/winit/pull/3966 is in the Winit release | ||
| // used by this example. | ||
| render_state.window.set_ime_cursor_area( | ||
| PhysicalPosition::new( |
There was a problem hiding this comment.
I think it is, but I haven't tested it with a non-1 display scale. The editor gets its width set as the physical width in
parley/examples/vello_editor/src/main.rs
Lines 228 to 235 in 85a824a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The area reported is the area of text the user is currently editing. It is usually used by platforms to place a candidate box for IME near it, while ensuring it is not obscured.
The implementation here ensures the area is usually near the focus, that the area contains at least some surrounding context (in case the platform places something to the side of the area, instead of above or under), and that the IME candidate box usually does not need to jump around when the IME starts or continues composing.