Convert approx_eq! calls to assert_approx_eq! #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking this on! Overall it looks good, but the changelog entry should be moved from the Added section to the Maintenance section, because this isn't actually a new feature that Druid users can use, but instead it involves internal tests. |
xStrom
added
maintenance
Resolves issue linebender#2140 No other changes were needed, all tests still passed after this change.
cbondurant
force-pushed
the
assert_approx_eq
branch
from
8b5c7c5 to
530dfc5
Compare
|
Gotcha. That amend should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #2140
No other changes were needed, all tests still passed after this change.