ExtEventSink::add_idle_callback #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes using commands to mutate data from ExtEventSink can be very verbose. This provides a simpler alternative.
jneem
requested changes
Sep 5, 2021
| let color_clone = color.clone(); | ||
| // schedule idle callback to change the data | ||
| event_sink.add_idle_callback(move |data: &mut Color| { | ||
| *data = color_clone; |
There was a problem hiding this comment.
I think this is totally the right way to do this, but maybe the previous code had some pedagogical value? Sometimes you really do want to send a command instead of mutate the data...
There was a problem hiding this comment.
I feel blocking_function example is sufficient for that 🤷♂️
|
Thanks! CI failure seems spurious... |
jneem
approved these changes
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes using commands to mutate data from ExtEventSink can be complicated and verbose.
This provides a simpler alternative.